Update Google Pay Version and add totalPriceLabel
#809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxdesmarais
approved these changes
Oct 23, 2023
| @@ -148,7 +148,7 @@ public static boolean isGooglePayEmailRequired(Context context) { | |||
| } | |||
|
|
|||
| public static String getGooglePayCurrency(Context context) { | |||
| return getPreferences(context).getString("google_pay_currency", "USD"); | |||
| return getPreferences(context).getString("google_pay_currency", "EUR"); | |||
There was a problem hiding this comment.
General q, is there a reason we want to set this to EUR for the demo vs USD?
There was a problem hiding this comment.
I was working to resolve this long-standing merchant request #321 but in testing discovered that the total price label seems to be visible depending on currency code. I reached out to Google Pay integration support to confirm which countries/currencies it should be visible for, so we can provide a definitive answer. For now, I figured it was better for demo if the label is visible, so I changed it to EUR as default.
There was a problem hiding this comment.
Ah, interesting that it's only available for certain currency codes. That makes sense though - thanks for the explanation!
sshropshire
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
play-services-walletdependency to latesttotalPriceLabelparameter toGooglePayRequestChecklist
Authors